chore: upgrade db packages by hwbrzzl · Pull Request #848 · goravel/framework

hwbrzzl · 2025-02-04T15:02:34Z

📑 Description

Summary by CodeRabbit

Chores
- Updated various dependency versions to align with the latest stable releases.
- Enhanced support for additional databases, including SQLite and SQL Server, in the testing environment for improved compatibility and performance.
- Incorporated other indirect dependency updates that contribute to overall stability and reliability.

coderabbitai · 2025-02-04T15:02:43Z

Walkthrough

This pull request updates the dependency configuration in the tests/go.mod file for the module. Specific dependencies have been updated to newer versions, including github.com/goravel/framework, github.com/goravel/mysql, and github.com/goravel/postgres. Additionally, new dependencies, namely github.com/goravel/sqlite and github.com/goravel/sqlserver, have been added, along with several new indirect dependencies. The overall require block remains structurally similar while reflecting the latest dependency versions.

Changes

File	Change Summary
tests/go.mod	- Updated versions for dependencies: `github.com/goravel/framework`, `github.com/goravel/mysql`, `github.com/goravel/postgres`, `golang.org/x/sync`, `golang.org/x/sys`, and `golang.org/x/text`. - Added new dependencies: `github.com/goravel/sqlite` and `github.com/goravel/sqlserver`. - Introduced several new indirect dependencies.

Possibly related PRs

chore: update tests #843: The changes in the main PR are related to updates in the go.mod file for the same dependencies (github.com/goravel/framework and github.com/goravel/postgres) as those in the retrieved PR, indicating a direct connection at the code level.

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d16d25 and 3034c97.

⛔ Files ignored due to path filters (1)

tests/go.sum is excluded by !**/*.sum

📒 Files selected for processing (1)

tests/go.mod (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/go.mod

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite	Current: `3034c97`	Previous: `9aa404b`	Ratio
`BenchmarkFile_ReadWrite`	`320995` ns/op 2072 B/op 27 allocs/op	`181949` ns/op 2072 B/op 27 allocs/op	`1.76`
`BenchmarkFile_ReadWrite - ns/op`	`320995` ns/op	`181949` ns/op	`1.76`

This comment was automatically generated by workflow using github-action-benchmark.

codecov · 2025-02-04T15:07:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (9aa404b) to head (3034c97).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files         150      150           
  Lines       10442    10442           
=======================================
  Hits         7013     7013           
  Misses       3055     3055           
  Partials      374      374

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

almas-x · 2025-02-05T10:10:23Z

framework/database/console/show_command.go

Line 108 in 9aa404b

name = r.schema.Orm().Name()

Unrelated to this PR, but just a quick note: the database names should follow their proper casing and full names—PostgreSQL, MySQL, MariaDB, SQL Server, and SQLite—instead of lowercase driver name like postgres, mysql, sqlite, or sqlserver.

hwbrzzl · 2025-02-05T10:19:03Z

framework/database/console/show_command.go

Line 108 in 9aa404b

name = r.schema.Orm().Name()

Unrelated to this PR, but just a quick note: the database names should follow their proper casing and full names—PostgreSQL, MySQL, MariaDB, SQL Server, and SQLite—instead of lowercase driver name like postgres, mysql, sqlite, or sqlserver.

@almas1992 Good catch, for r.schema.Orm().Name() , I think postgres, mysql, sqlite, or sqlserver should be good, we may need another method to get the DB name?

almas-x · 2025-02-05T10:30:58Z

framework/database/console/show_command.go

Line 108 in 9aa404b

name = r.schema.Orm().Name()

Unrelated to this PR, but just a quick note: the database names should follow their proper casing and full names—PostgreSQL, MySQL, MariaDB, SQL Server, and SQLite—instead of lowercase driver name like postgres, mysql, sqlite, or sqlserver.

@almas1992 Good catch, for r.schema.Orm().Name() , I think postgres, mysql, sqlite, or sqlserver should be good, we may need another method to get the DB name?

I think adding a new method to retrieve the DB name works(Laravel has getDatabseTitle method), or we could handle it with a mapping in the command. We’ll just need to add some special handling for MySQL and MariaDB

almas-x

LGTM! 🚀

hwbrzzl · 2025-02-05T10:38:31Z

@almas1992 Could you create an issue to trace this?

almas-x · 2025-02-05T10:41:38Z

@almas1992 Could you create an issue to trace this?

Okay

chore: upgrade db packages

7d16d25

hwbrzzl added the 🚀 Review Ready label Feb 4, 2025

hwbrzzl requested a review from a team as a code owner February 4, 2025 15:02

github-actions bot reviewed Feb 4, 2025

View reviewed changes

hwbrzzl added 2 commits February 5, 2025 17:53

update mod

6bdf875

Merge branch 'master' into bowen/#540-2

3034c97

almas-x reviewed Feb 5, 2025

View reviewed changes

hwbrzzl merged commit ffb840d into master Feb 5, 2025
13 of 14 checks passed

hwbrzzl deleted the bowen/#540-2 branch February 5, 2025 10:38

coderabbitai bot mentioned this pull request Feb 7, 2025

chore(deps): Update tests module #854

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade db packages#848

chore: upgrade db packages#848
hwbrzzl merged 3 commits intomasterfrom
bowen/#540-2

hwbrzzl commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

codecov bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

almas-x commented Feb 5, 2025

Uh oh!

hwbrzzl commented Feb 5, 2025

Uh oh!

almas-x commented Feb 5, 2025 •

edited

Loading

Uh oh!

almas-x left a comment •

edited

Loading

Uh oh!

hwbrzzl commented Feb 5, 2025

Uh oh!

Uh oh!

almas-x commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hwbrzzl commented Feb 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

codecov bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

almas-x commented Feb 5, 2025

Uh oh!

hwbrzzl commented Feb 5, 2025

Uh oh!

almas-x commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

almas-x left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hwbrzzl commented Feb 5, 2025

Uh oh!

Uh oh!

almas-x commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hwbrzzl commented Feb 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot left a comment •

edited

Loading

codecov bot commented Feb 4, 2025 •

edited

Loading

almas-x commented Feb 5, 2025 •

edited

Loading

almas-x left a comment •

edited

Loading