Skip to content

feat: [#398] Add a -f flag for make commands, to avoid cover the existing file by mistake#480

Merged
krishankumar01 merged 20 commits intomasterfrom
kkumar-gcc/#398-fix
May 22, 2024
Merged

feat: [#398] Add a -f flag for make commands, to avoid cover the existing file by mistake#480
krishankumar01 merged 20 commits intomasterfrom
kkumar-gcc/#398-fix

Conversation

@krishankumar01
Copy link
Member

@krishankumar01 krishankumar01 commented May 21, 2024 •
edited
Loading

Closes goravel/goravel#398

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@krishankumar01 krishankumar01 changed the title add force flag in make commands feat: [#398] Add a -f flag for make commands, to avoid cover the existing file by mistake May 21, 2024
@codecov
Copy link

codecov bot commented May 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.25581% with 122 lines in your changes are missing coverage. Please review.

Project coverage is 69.70%. Comparing base (db882c7) to head (3871235).

Files Patch % Lines
auth/console/policy_make_command.go 36.36% 7 Missing ⚠️
database/console/factory_make_command.go 30.00% 7 Missing ⚠️
database/console/model_make_command.go 30.00% 7 Missing ⚠️
database/console/observer_make_command.go 30.00% 7 Missing ⚠️
database/console/seeder_make_command.go 30.00% 7 Missing ⚠️
event/console/event_make_command.go 36.36% 7 Missing ⚠️
event/console/listener_make_command.go 36.36% 7 Missing ⚠️
foundation/console/test_make_command.go 36.36% 7 Missing ⚠️
http/console/middleware_make_command.go 36.36% 7 Missing ⚠️
http/console/request_make_command.go 36.36% 7 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   70.37%   69.70%   -0.67%     
==========================================
  Files         173      174       +1     
  Lines       10594    10721     +127     
==========================================
+ Hits         7455     7473      +18     
- Misses       2572     2681     +109     
  Partials      567      567

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krishankumar01 krishankumar01 requested a review from a team May 21, 2024 06:51
hwbrzzl
hwbrzzl reviewed May 21, 2024
View reviewed changes
hwbrzzl
hwbrzzl reviewed May 22, 2024
View reviewed changes
hwbrzzl
hwbrzzl approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@krishankumar01 krishankumar01 merged commit bf400e0 into master May 22, 2024
@krishankumar01 krishankumar01 deleted the kkumar-gcc/#398-fix branch May 22, 2024 13:08
@coderabbitai coderabbitai bot mentioned this pull request Sep 5, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

✨ [Feature] Add a -f flag for make commands, to avoid cover the existing file by mistake

2 participants

@krishankumar01 @hwbrzzl