chore: confirm sequential reuse of runner in build command is safe#1404
Closed
Copilot wants to merge 1 commit intoalmas/chorefrom
Closed
chore: confirm sequential reuse of runner in build command is safe#1404Copilot wants to merge 1 commit intoalmas/chorefrom
Copilot wants to merge 1 commit intoalmas/chorefrom
Conversation
1 task
Copilot
AI
changed the title
[WIP] WIP address feedback on adding generate flag to artisan build command
chore: confirm sequential reuse of runner in build command is safe
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a review question on whether
runner(a mutable*Process) can be safely reused across thego generateandgo buildsteps inBuildCommand.Handle.Finding
Processis mutable —Env(),WithSpinner(), and all builder methods modify the struct in-place and return the same pointer.Run()calls are sequential: eachWithSpinner("…")overwrites the spinner message before itsRun(), and the env vars (GOOS,GOARCH,CGO_ENABLED) set once persist across both runs as intended.No code changes were required.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.