Skip to content

fix: add test dbs back#1346

Merged
hwbrzzl merged 1 commit intov1.16.xfrom
bowen/#856-2
Jan 10, 2026
Merged

fix: add test dbs back#1346
hwbrzzl merged 1 commit intov1.16.xfrom
bowen/#856-2

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jan 10, 2026

📑 Description

Closes goravel/goravel#856

Follow Gemini

✅ Checks

  • Added test cases for my code

@hwbrzzl hwbrzzl requested a review from a team as a code owner January 10, 2026 13:36
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 10, 2026

Summary of Changes

Hello @hwbrzzl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the testing infrastructure by reintroducing support for MySQL, SQL Server, and SQLite database queries within the test suite. The change ensures that the application's interactions with these database systems are properly validated, aligning with a broader initiative to follow 'Gemini' standards and directly resolving a previously identified issue.

Highlights

  • Database Test Re-enablement: Re-enabled test database queries for MySQL, SQL Server, and SQLite by uncommenting their initialization and inclusion in the All method within tests/query.go.
  • Issue Resolution: This pull request addresses and closes issue fix: Throw error if Context is http Context #856, which likely concerned the absence or disablement of these specific database tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 10, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables tests for MySQL, SQL Server, and SQLite databases by uncommenting the relevant code in the All method. The change is correct and achieves its goal. I've added a suggestion to refactor the All method for better readability and consistency with other parts of the code.

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v1.16.x@c709cdc). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff             @@
##             v1.16.x    #1346   +/-   ##
==========================================
  Coverage           ?   68.04%           
==========================================
  Files              ?      215           
  Lines              ?    11601           
  Branches           ?        0           
==========================================
  Hits               ?     7894           
  Misses             ?     3327           
  Partials           ?      380

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwbrzzl hwbrzzl merged commit f7dca2e into v1.16.x Jan 10, 2026
17 checks passed
@hwbrzzl hwbrzzl deleted the bowen/#856-2 branch January 10, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🚀 Review Ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hwbrzzl