Skip to content

fix: [#858] facades.DB().Insert() can not operate nil columns as expected#1344

Merged
hwbrzzl merged 2 commits intov1.16.xfrom
bowen/#858
Jan 10, 2026
Merged

fix: [#858] facades.DB().Insert() can not operate nil columns as expected#1344
hwbrzzl merged 2 commits intov1.16.xfrom
bowen/#858

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jan 9, 2026

📑 Description

Closes goravel/goravel#858

Follow Gemini

✅ Checks

  • Added test cases for my code

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 9, 2026

Summary of Changes

Hello @hwbrzzl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the facades.DB().Insert() method where nil columns were not being processed as expected, leading to potential data integrity issues. The changes ensure that the database insertion mechanism robustly handles optional fields and complex data structures by correctly identifying all relevant columns across multiple records. This significantly improves the reliability of bulk insert operations.

Highlights

  • Improved Insert Operation Logic: The buildInsert function now correctly identifies all columns across multiple data entries, ensuring that nil columns are properly handled during database insertions. This resolves the issue where facades.DB().Insert() failed to operate nil columns as expected.
  • Simplified Column Name Mapping: The NameMapper function in database/db/builder.go has been streamlined by removing a specific rule that handled the 'ID' column differently, promoting a more consistent naming convention.
  • Enhanced Test Coverage: New test cases have been added to TestConvertToSliceMap in database/db/utils_test.go to thoroughly validate the Insert functionality with various data structures, including nested structs, pointer fields, and scenarios involving nil values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where Insert() with multiple data maps would only consider the columns from the first map. The logic is now updated to collect all unique columns from all provided maps, ensuring all data is correctly prepared for insertion. However, the new tests introduce nested structs which are not properly handled. The buildInsert function does not process these struct values before passing them to the database driver, which will likely cause a runtime error. I've added a comment with a suggestion to address this.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v1.16.x@6460b24). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff             @@
##             v1.16.x    #1344   +/-   ##
==========================================
  Coverage           ?   68.04%           
==========================================
  Files              ?      215           
  Lines              ?    11601           
  Branches           ?        0           
==========================================
  Hits               ?     7894           
  Misses             ?     3327           
  Partials           ?      380

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hwbrzzl hwbrzzl marked this pull request as ready for review January 9, 2026 10:15
@hwbrzzl hwbrzzl requested a review from a team as a code owner January 9, 2026 10:15
@hwbrzzl hwbrzzl merged commit c709cdc into v1.16.x Jan 10, 2026
17 checks passed
@hwbrzzl hwbrzzl deleted the bowen/#858 branch January 10, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🚀 Review Ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hwbrzzl