Why is the instrumentation needed instead of log directly? And the files in the log folder are for the log channel. Can they be moved to the framework/log folder directly?

And for the new configuration:

// config/telemetry.go
"instrumentation": map[string]any{
    "log": map[string]any{
        "enabled": true,
        "name":    "goravel/log",
    },
},

Is it required? Can it be removed? It can be considered as enabled if user uses the log channel.

And for the log configuration:

"otel": map[string]any{
    "driver": "custom",
    "via":    telemetrylog.NewTelemetryChannel(),
},

We can set otel as the framework internal driver:

"otel": map[string]any{
	"driver": "otel",
	...
},

That makes sense. I agree that exposing it as a native driver is cleaner, it removes the need for the separate telemetry config since adding the driver effectively 'enables' it. But I don't want to add a direct dependencies on telemetry pacakge when we use package:install command to install log package.

Regarding the file location, I’d prefer to keep it in instrumentation/log. I plan to add other OTel instrumentations (like http_server and http_client) soon, and grouping all the OTel adapters together under telemetry/instrumentation/ keeps the project structure much more organized than scattering them across different packages.

Good point, it's heavy to install Telemetry when installing Log, given that most users should not use Telemetry. It's fine to keep the new hook in instrumentation/log, but the otel log driver can be kept as well, the configuration below can be added when installing the Telemetry facade.

"otel": map[string]any{
    "driver": "custom",
    "via":    telemetrylog.NewTelemetryChannel(),
},

But the OpenTelemetry log driver can be kept as well.

Do we need to expose this channel as both the otel log driver and a custom one?

The configuration below can be added when installing the Telemetry facade.

Good idea, I’ll add this to the setup file so it gets registered automatically.

Only the otel log driver should be fine, and the otel driver doesn't need to be pointed out in the log config, given that it will be added to the log config when installing Telemetry.

@hwbrzzl By the way, we need to optimize the log.WithContext method. Currently, it returns an instance of log.Writer, and because of this we can’t use:

facades.Log().WithContext(ctx).Channel("otel").Info()

Because we should be able to pass the ctx even when we use inline channel and stacked method calling.

Yes, good catch. We can create an issue for it.

Created an issue for above 👍

@hwbrzzl Can you please review it again? I have added setup to automatically register this new channel in logging.go