Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: eb936ad | Previous: d735058 | Ratio |
|---|---|---|---|
Benchmark_DecryptString |
5834 ns/op 2032 B/op 16 allocs/op |
2425 ns/op 2032 B/op 16 allocs/op |
2.41 |
Benchmark_DecryptString - ns/op |
5834 ns/op |
2425 ns/op |
2.41 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
==========================================
+ Coverage 68.91% 69.14% +0.23%
==========================================
Files 265 265
Lines 15732 15671 -61
==========================================
- Hits 10841 10836 -5
+ Misses 4424 4368 -56
Partials 467 467 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors variable names across the codebase for improved consistency and clarity. The main changes include pluralizing path configuration field names (e.g., Command → Commands, Model → Models) and restructuring package setup utilities to use instance methods instead of global functions.
Key changes:
- Pluralized all path configuration field names in
support.Pathsstruct for grammatical consistency - Moved
GetModulePath()andGetPackageName()from global functions to instance methods on theSetupinterface - Relocated
PackageName()utility tosupport/envpackage for better organization - Simplified facade installation logic by removing conditional
WhenFacade/WhenNoFacadeswrappers in most setup files
Reviewed changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| support/variable.go | Renamed all path fields from singular to plural form (e.g., Command→Commands, Model→Models) and updated documentation |
| support/env/env.go | Added PackageName() function relocated from packages.Setup for better package organization |
| support/env/env_test.go | Added test coverage for the new PackageName() function |
| packages/setup.go | Removed global utility functions (GetModulePath, GetPackageName, GetModuleNameFromArgs) and converted to instance methods |
| packages/setup_test.go | Removed tests for deprecated global functions |
| contracts/packages/setup.go | Added ModulePath() to Setup interface and enhanced documentation for all methods |
| mocks/packages/Setup.go | Generated mock implementation for new ModulePath() method |
| foundation/configuration/paths.go | Updated all setter methods to use pluralized path field names |
| foundation/configuration/paths_test.go | Updated test assertions to verify pluralized field names |
| foundation/application.go | Updated ModelPath() to reference Models instead of Model |
| foundation/console/*.go | Updated console commands to use pluralized path fields and env.PackageName() |
| database/migration/creator.go | Updated migration path reference to use Migrations instead of Migration |
| database/console/*.go | Updated all make commands to use pluralized path field names |
| database/setup/setup.go | Refactored to use setup instance methods and removed WhenFacade conditional wrappers |
| /console/.go | Updated all console make commands across modules to use pluralized path configuration fields |
| */setup/setup.go | Refactored all module setup files to use Setup instance methods and simplified facade installation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Related issue: goravel/goravel#423
This pull request refactors the codebase to standardize path naming conventions and improve the setup process for multiple packages. The main changes include renaming singular path variables to their plural forms throughout the code, updating setup scripts to use a unified
Setupinterface, and ensuring consistency in how modules and package names are retrieved and used.Path Naming Standardization
support.Config.Paths.Model,support.Config.Paths.Event) to their plural forms (e.g.,support.Config.Paths.Models,support.Config.Paths.Events) across the codebase, affecting command handlers and configuration methods. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Setup Script Refactoring
auth,cache,crypt,database,event,filesystem) to use the newSetupinterface, replacing direct calls topackages.GetModulePath()andpackages.GetModuleNameFromArgs(os.Args)with methods from theSetupobject for improved consistency and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Setup Interface Enhancement
Setupinterface incontracts/packages/setup.goby adding method documentation and new methods (Execute,ModulePath,PackageName,Install,Uninstall) to formalize and clarify the setup workflow.Consistency Improvements
Setupobject, reducing potential errors and improving code clarity. [1] [2] [3] [4] [5] [6] [7] [8] [9]These changes collectively make the codebase more maintainable and consistent, especially as the project grows to support more packages and features.
✅ Checks