feat: [#822] Remove unnecessary code and add missing code when installing all facades#1284
feat: [#822] Remove unnecessary code and add missing code when installing all facades#1284
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1284 +/- ##
==========================================
- Coverage 68.90% 68.61% -0.30%
==========================================
Files 264 264
Lines 15515 15632 +117
==========================================
+ Hits 10691 10726 +35
- Misses 4363 4442 +79
- Partials 461 464 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request removes all kernel file management logic from setup scripts across database, gRPC, HTTP, and schedule modules, simplifying the installation and uninstallation processes.
- Eliminates creation, modification checks, and conditional deletion of kernel.go files
- Removes associated helper functions (
isKernelNotModified) - Cleans up unused imports and updates comments to reflect the changes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| schedule/setup/setup.go | Removed console kernel.go creation/deletion logic, isKernelNotModified helper function, and unused imports (file, stubs) |
| http/setup/setup.go | Removed app/http/kernel.go creation and deletion, updated comments to exclude kernel file references |
| grpc/setup/setup.go | Removed app/grpc/kernel.go creation and deletion, updated comments to exclude kernel file references |
| database/setup/setup.go | Removed database kernel.go creation/deletion logic and isKernelNotModified helper function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: f170ce0 | Previous: 4866257 | Ratio |
|---|---|---|---|
Benchmark_DecryptString |
5478 ns/op 2032 B/op 16 allocs/op |
2083 ns/op 2032 B/op 16 allocs/op |
2.63 |
Benchmark_DecryptString - ns/op |
5478 ns/op |
2083 ns/op |
2.63 |
This comment was automatically generated by workflow using github-action-benchmark.
📑 Description
Closes goravel/goravel#822
This pull request makes several significant improvements and simplifications to the setup and modification logic for database, HTTP, and gRPC modules, as well as enhances the helper matching utilities with comprehensive documentation and new matching capabilities. The most important changes include removing the creation and management of
kernel.gofiles from setup scripts, refactoring route registration logic for gRPC, and adding new helper methods and documentation for code matching utilities.Setup script simplification and cleanup
kernel.gofiles fromdatabase/setup/setup.go,http/setup/setup.go, andgrpc/setup/setup.go. This streamlines the setup and uninstall processes by eliminating unnecessary file management. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Route registration and removal improvements
AddRouteApplyandRemoveRouteApplymethods, and updated the setup logic to add/remove the Grpc function in the routing setup. This makes route management more modular and easier to maintain. [1] [2] [3] [4] [5]Enhanced match helper utilities
Added thorough documentation comments to all matcher helper functions in
packages/match/helper.go, explaining their purpose, usage, and examples. This greatly improves code readability and developer onboarding. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Added new matcher functions for common patterns:
RegisterFunc,BootFunc,Seeders,ValidationRules, andValidationFilters, enabling more precise and automated code modifications for service providers and validation logic. [1] [2] [3]Minor refactoring for consistency
routesPathfrom configuration and constructing route function names dynamically.These changes collectively make the framework's setup and code modification processes more maintainable, extensible, and developer-friendly.
✅ Checks