Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 68.56% 68.57%
=======================================
Files 264 264
Lines 15566 15611 +45
=======================================
+ Hits 10673 10705 +32
- Misses 4430 4443 +13
Partials 463 463 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for the WithFilters function to the ApplicationBuilder, enabling users to register validation filters through the new bootstrap-based setup pattern (foundation.Setup() chain). This complements the existing WithRules functionality and addresses issue #821.
Key Changes:
- Added
WithFilters()method to ApplicationBuilder for registering validation filters - Enhanced filter make command to support both bootstrap and kernel-based registration
- Created comprehensive utility functions and matchers for filter registration
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/foundation/application_builder.go | Added WithFilters method to ApplicationBuilder interface |
| foundation/application_builder.go | Implemented WithFilters method and filter registration logic |
| foundation/application_builder_test.go | Added comprehensive tests for WithFilters functionality |
| validation/console/filter_make_command.go | Updated to support both bootstrap and kernel registration patterns |
| validation/console/filter_make_command_test.go | Added extensive tests covering bootstrap and non-bootstrap scenarios |
| packages/modify/utils.go | Added AddFilter utility function following existing patterns |
| packages/modify/utils_test.go | Added comprehensive tests for AddFilter function |
| packages/modify/with_slice_actions.go | Enhanced documentation for AddItem method |
| packages/modify/stubs.go | Added filters stub template for bootstrap setup |
| packages/match/helper.go | Added Filters matcher for Go node matching |
| errors/list.go | Added PackageFiltersFileExists error message |
| mocks/foundation/ApplicationBuilder.go | Generated mock for WithFilters method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📑 Description
Closes goravel/goravel#821
✅ Checks