Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1260 +/- ##
==========================================
+ Coverage 67.93% 67.96% +0.03%
==========================================
Files 261 261
Lines 15177 15186 +9
==========================================
+ Hits 10310 10321 +11
+ Misses 4424 4423 -1
+ Partials 443 442 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 6be9280 | Previous: 6918a00 | Ratio |
|---|---|---|---|
Benchmark_DecryptString |
5634 ns/op 2032 B/op 16 allocs/op |
2187 ns/op 2032 B/op 16 allocs/op |
2.58 |
Benchmark_DecryptString - ns/op |
5634 ns/op |
2187 ns/op |
2.58 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for registering scheduled events in the application builder, enhancing the framework's scheduling capabilities by providing a fluent interface for scheduling configuration during application setup.
- Introduces
WithSchedulemethod to set scheduled events for the application - Adds scheduled event registration logic in the
Create()method with proper error handling - Includes comprehensive test coverage and mock implementations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contracts/foundation/application_builder.go | Adds WithSchedule method signature to the ApplicationBuilder interface |
| foundation/application_builder.go | Implements WithSchedule method and adds scheduled event registration logic in Create() |
| foundation/application_builder_test.go | Adds comprehensive test cases for WithSchedule functionality covering success and error scenarios |
| mocks/foundation/ApplicationBuilder.go | Adds mock implementation for WithSchedule method following the established pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📑 Description
Closes goravel/goravel#795
This pull request adds support for registering scheduled events in the application builder, enhancing the framework's scheduling capabilities. The changes introduce a new method to set scheduled events, update the builder's internal state, and ensure scheduled events are registered during application creation. Mock support for the new scheduling feature is also included.
✅ Checks