Skip to content

feat: [#789] [SUB-786] Init the basic structure#1230

Merged
hwbrzzl merged 1 commit intomasterfrom
bowen/#789
Oct 18, 2025
Merged

feat: [#789] [SUB-786] Init the basic structure#1230
hwbrzzl merged 1 commit intomasterfrom
bowen/#789

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Oct 16, 2025

📑 Description

Closes goravel/goravel#789

image

✅ Checks

  • Added test cases for my code

@hwbrzzl hwbrzzl requested a review from a team as a code owner October 16, 2025 12:50
Copilot AI review requested due to automatic review settings October 16, 2025 12:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new ApplicationBuilder pattern to the Goravel framework, providing a fluent interface for configuring and creating application instances. The implementation follows the builder pattern to allow for method chaining and flexible application setup.

  • Adds ApplicationBuilder interface and implementation with Create, Run, and WithConfig methods
  • Provides mock implementation for testing ApplicationBuilder functionality
  • Includes comprehensive test coverage for all ApplicationBuilder methods

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
contracts/foundation/application.go Defines the ApplicationBuilder interface contract
foundation/application_builder.go Implements the ApplicationBuilder pattern with fluent API
foundation/application_builder_test.go Comprehensive tests for ApplicationBuilder functionality
mocks/foundation/ApplicationBuilder.go Auto-generated mock for testing ApplicationBuilder

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.95%. Comparing base (a136858) to head (c85fc55).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
foundation/application_builder.go 68.42% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   65.95%   65.95%           
=======================================
  Files         243      244    +1     
  Lines       16698    16717   +19     
=======================================
+ Hits        11013    11026   +13     
- Misses       5304     5310    +6     
  Partials      381      381           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 2d07c62 into master Oct 18, 2025
14 checks passed
@hwbrzzl hwbrzzl deleted the bowen/#789 branch October 18, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SUB-786] Init the basic structure

3 participants