feat: [#576] Optimize package install process#1226
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the package installation command interface to improve user experience by replacing a multi-select interface with a choice-based flow. Instead of presenting all facades in a single multi-select, users now choose between installing all facades, selecting specific facades, or installing a third-party package.
- Replaced multi-select facade selection with a three-option choice menu
- Added dedicated methods for facade selection and third-party package input
- Updated test cases to cover the new choice-based workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| foundation/console/package_install_command.go | Refactored main installation logic to use choice-based flow and extracted facade selection and package input into separate methods |
| foundation/console/package_install_command_test.go | Updated test cases to reflect new choice-based interface and added coverage for new error scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
+ Coverage 66.68% 66.69% +0.01%
==========================================
Files 237 237
Lines 15892 15918 +26
==========================================
+ Hits 10597 10617 +20
- Misses 4929 4933 +4
- Partials 366 368 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| options := []console.Choice{ | ||
| {Key: "All facades", Value: "all"}, | ||
| {Key: "Select facades", Value: "select"}, | ||
| {Key: "Third package", Value: "third"}, |
There was a problem hiding this comment.
Third package sounds a bit confusing, did you mean Third-party packages?
There was a problem hiding this comment.
Good catch, updated.
📑 Description
Relate goravel/goravel#576
✅ Checks