Skip to content

feat: add make:provider Command#1180

Merged
hwbrzzl merged 4 commits intogoravel:masterfrom
BadJacky:feature/add-make-provider-command
Sep 5, 2025
Merged

feat: add make:provider Command#1180
hwbrzzl merged 4 commits intogoravel:masterfrom
BadJacky:feature/add-make-provider-command

Conversation

@BadJacky
Copy link
Contributor

@BadJacky BadJacky commented Sep 3, 2025

📑 Description

Closes https://github.com/goravel/goravel/issues/

  • Add ProviderMakeCommand with --force/-f option support
  • Create ServiceProvider stub template with complete interface implementation
  • Add comprehensive test suite covering all scenarios
  • Register command in foundation application bootstrap
  • Generated providers include Relationship(), Register(), and Boot() methods
  • Support nested provider creation (e.g., auth/CustomProvider)
  • Default output directory: app/providers/

✅ Checks

  • Added test cases for my code

- Add DateTimes method to Blueprint interface
- Implement DateTimes method to create created_at and updated_at columns
- Add precision parameter support for timestamp columns
- Add test coverage for DateTimes functionality
@BadJacky BadJacky requested a review from a team as a code owner September 3, 2025 15:04
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 90.27778% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.27%. Comparing base (f716e5a) to head (10a2467).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
foundation/console/provider_make_command.go 84.61% 5 Missing and 1 partial ⚠️
foundation/application.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
+ Coverage   68.17%   68.27%   +0.10%     
==========================================
  Files         232      233       +1     
  Lines       14999    15071      +72     
==========================================
+ Hits        10225    10290      +65     
- Misses       4395     4401       +6     
- Partials      379      380       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BadJacky BadJacky marked this pull request as draft September 3, 2025 15:09
@BadJacky BadJacky force-pushed the feature/add-make-provider-command branch from fc434e3 to d195033 Compare September 3, 2025 15:11
@BadJacky BadJacky marked this pull request as ready for review September 3, 2025 15:18
@BadJacky BadJacky force-pushed the feature/add-make-provider-command branch from 18985ce to 8bbf0f6 Compare September 5, 2025 10:34
@BadJacky
Copy link
Contributor Author

BadJacky commented Sep 5, 2025

@hwbrzzl checked & pushed , let me know if there has any issues or suggestions.

@BadJacky BadJacky force-pushed the feature/add-make-provider-command branch from 8bbf0f6 to ce7c99f Compare September 5, 2025 10:43
  - Add ProviderMakeCommand with --force/-f option support
  - Create ServiceProvider stub template with complete interface implementation
  - Add comprehensive test suite covering all scenarios
  - Register command in foundation application bootstrap
  - Generated providers include Relationship(), Register(), and Boot() methods
  - Support nested provider creation (e.g., auth/CustomProvider)
  - Default output directory: app/providers/

Update foundation/console/stubs.go

Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>

Update foundation/console/stubs.go

Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
@BadJacky BadJacky force-pushed the feature/add-make-provider-command branch from ce7c99f to 10a2467 Compare September 5, 2025 14:14
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hwbrzzl hwbrzzl merged commit 4cd93b0 into goravel:master Sep 5, 2025
15 of 16 checks passed
@BadJacky BadJacky deleted the feature/add-make-provider-command branch September 5, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants