chore: [#735] Remove github.com/RichardKnop/machinery#1140
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the GitHub.com/RichardKnop/machinery queue driver from the Goravel framework, as it's no longer supported in v1.17. The changes systematically eliminate all machinery-related code, configuration, and dependencies while maintaining the existing queue system for other drivers.
- Removes the "machinery" driver from queue system and updates supported drivers to sync, database, and custom only
- Deletes all machinery-specific implementation files including driver, logging, and test files
- Cleans up go.mod dependencies by removing machinery and its transitive dependencies
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| queue/worker.go | Removes machinery worker support and RunMachinery method |
| queue/setup/config/queue.go | Removes machinery configuration example from queue connections |
| queue/driver_machinery_test.go | Deletes entire machinery driver test suite |
| queue/driver_machinery_log.go | Deletes machinery logging adapter implementation |
| queue/driver_machinery.go | Deletes complete machinery driver implementation |
| queue/driver_creator_test.go | Removes machinery driver test case from driver creator tests |
| queue/driver_creator.go | Removes machinery driver case from driver creation logic |
| go.mod | Removes machinery dependency and associated transitive dependencies |
| errors/list.go | Removes machinery-specific error constant |
| contracts/queue/driver.go | Removes DriverMachinery constant from supported drivers |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1140 +/- ##
==========================================
+ Coverage 66.83% 67.70% +0.87%
==========================================
Files 215 213 -2
Lines 14071 13787 -284
==========================================
- Hits 9404 9335 -69
+ Misses 4291 4079 -212
+ Partials 376 373 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#735
It's not supported in v1.17 anymore.
✅ Checks