Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1103 +/- ##
==========================================
- Coverage 66.79% 66.76% -0.03%
==========================================
Files 212 212
Lines 14011 14001 -10
==========================================
- Hits 9358 9348 -10
Misses 4283 4283
Partials 370 370 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ServiceProvider class to consolidate three methods (Bindings, Dependencies, and ProvideFor) into a single Relationship method that returns a structured binding.Relationship object.
- Removed redundant methods and replaced them with the Relationship method.
- Simplified the code structure in foundation/console/package_make_command_stubs.go.
Comments suppressed due to low confidence (1)
foundation/console/package_make_command_stubs.go:40
- Consider expanding the documentation for the Relationship method to include details on what each field (Bindings, Dependencies, ProvideFor) represents, as this information was previously covered in the individual methods.
// Relationship returns the relationship of the service provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#667
This pull request refactors the
ServiceProviderclass infoundation/console/package_make_command_stubs.goto consolidate multiple methods into a singleRelationshipmethod. This change simplifies the code and provides a more structured representation of bindings, dependencies, and services provided by the service provider.Refactoring of
ServiceProviderclass:foundation/console/package_make_command_stubs.go: Replaced theBindings,Dependencies, andProvideFormethods with a singleRelationshipmethod, which returns abinding.Relationshipobject containing structured data for bindings, dependencies, and services provided.✅ Checks