chore: [#1074] add unit tests for JSON queries#1075
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the database driver dependencies in go.mod and refactors JSON path handling in the schema wrap functions.
- Upgraded several indirect dependencies, including redis/go-redis from v9.5.1 to v9.8.0.
- Added new indirect dependencies for goravel/mysql, postgres, sqlite, and sqlserver.
- Refactored regex usage in database/schema/wrap.go to use precompiled regex variables.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Upgraded database driver versions and added new indirect dependency requirements. |
| database/schema/wrap.go | Updated JSON path functions to use precompiled regex patterns for improved performance and clarity. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1075 +/- ##
=======================================
Coverage 71.03% 71.03%
=======================================
Files 181 181
Lines 12710 12710
=======================================
Hits 9028 9028
Misses 3312 3312
Partials 370 370 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8921bec to
21066ca
Compare
a5dcbb2 to
a4358a8
Compare
ff5fd84 to
482eafc
Compare
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 94de0fd | Previous: 462e3c1 | Ratio |
|---|---|---|---|
Benchmark_Fatal |
2e-7 ns/op 0 B/op 0 allocs/op |
1e-7 ns/op 0 B/op 0 allocs/op |
2 |
Benchmark_Fatal - ns/op |
2e-7 ns/op |
1e-7 ns/op |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
530438e to
3256990
Compare
hwbrzzl
reviewed
Jun 14, 2025
Contributor
hwbrzzl
left a comment
There was a problem hiding this comment.
Nice, could you add some or test casts?
Contributor
Author
Okay |
d97f7e5 to
8463677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#705
✅ Checks