Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures timestamp columns preserve timezone metadata by switching from Timestamps to TimestampsTz in migrations and tests, and removes now-obsolete manual stubs.
- Swapped
table.Timestamps()calls totable.TimestampsTz()in the default dummy migration and creator tests - Deleted dialect-specific stub implementations from
stubs.go, consolidating stub logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| database/migration/stubs.go | Updated default dummy migration to use TimestampsTz and removed manual stubs for drivers |
| database/migration/creator_test.go | Updated test to expect TimestampsTz instead of Timestamps |
Comments suppressed due to low confidence (2)
database/migration/stubs.go:89
- There are no tests covering the timezone-aware output for dialect-specific migration stubs. Consider adding tests to validate that stub generation for each driver includes timezone-aware timestamp definitions.
}
database/migration/stubs.go:48
- Removing the dialect-specific stub implementations will break migration generation for MySQL, Postgres, SQLite, and SQLServer. Please reinstate or regenerate these stubs with timezone-aware timestamp columns rather than deleting them entirely.
table.TimestampsTz()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1061 +/- ##
=======================================
Coverage 71.31% 71.31%
=======================================
Files 181 181
Lines 12732 12732
=======================================
Hits 9080 9080
Misses 3263 3263
Partials 389 389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hwbrzzl
commented
Jun 5, 2025
| func (receiver PostgresStubs) CreateUp() string { | ||
| return `CREATE TABLE DummyTable ( | ||
| id SERIAL PRIMARY KEY NOT NULL, | ||
| created_at timestamp NOT NULL, |
Contributor
Author
There was a problem hiding this comment.
Yes, but it's removed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#699
Currently, for
Timestampscolumn of Postgres and Sqlserver,2025-06-05 14:46:29 +08:00will be saved with2025-06-05 14:46:29, but when reading, ORM considers that the timezone is UTC, the timezone metadata is missed.✅ Checks