chore: [#669] upgrade DB packages and add test case#1045
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the goravel/postgres test dependency and adds a new schema test for PostgreSQL's GENERATED AS identity columns.
- Bumps
goravel/postgresto a newer commit intests/go.mod - Introduces
TestGeneratedAs_Postgresto validate default and custom identity column behaviors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/schema_test.go | Add TestGeneratedAs_Postgres to exercise identity column creation and querying |
| tests/go.mod | Update github.com/goravel/postgres version |
Comments suppressed due to low confidence (1)
tests/schema_test.go:1823
- [nitpick] Go test names typically avoid underscores; consider renaming to
TestGeneratedAsPostgresfor consistency with Go conventions.
func (s *SchemaSuite) TestGeneratedAs_Postgres() {
|
|
||
| func (s *SchemaSuite) TestGeneratedAs_Postgres() { | ||
| if s.driverToTestQuery[postgres.Name] == nil { | ||
| s.T().Skip("Skip test") |
There was a problem hiding this comment.
[nitpick] Provide a more descriptive skip message, e.g., Skip GENERATED AS identity tests for non-Postgres drivers to clarify why the test is skipped.
Suggested change
| s.T().Skip("Skip test") | |
| s.T().Skip("Skip GENERATED AS identity tests for non-Postgres drivers") |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1045 +/- ##
=======================================
Coverage 70.48% 70.48%
=======================================
Files 176 176
Lines 12339 12339
=======================================
Hits 8697 8697
Misses 3261 3261
Partials 381 381 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#669
✅ Checks