Skip to content

Client: introduce the retry func (honor 429 http code)#144

Merged
jtopjian merged 8 commits intogophercloud:masterfrom
kayrus:retry-func
Feb 2, 2021
Merged

Client: introduce the retry func (honor 429 http code)#144
jtopjian merged 8 commits intogophercloud:masterfrom
kayrus:retry-func

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Jan 31, 2021

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Jan 31, 2021

@jtopjian ready for review

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Feb 1, 2021

Depends on gophercloud/gophercloud#2106
I'd like to reuse the RetryFunc type pattern here as well.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Feb 1, 2021

@jtopjian feel free to update gophercloud in go.mod after merging the gophercloud/gophercloud#2106
and this PR also can be merged. Thanks in advance.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit eca7831 into gophercloud:master Feb 2, 2021
@kayrus kayrus deleted the retry-func branch February 2, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants