Compute v2: Flavor Access Remove#688
Merged
jrperritt merged 2 commits intogophercloud:masterfrom Jan 19, 2018
Merged
Conversation
|
Build failed.
|
418fb7b to
12f9b93
Compare
|
Build succeeded.
|
12f9b93 to
676f4c6
Compare
|
Build succeeded.
|
|
Build succeeded.
|
2030088 to
391f1a3
Compare
1 similar comment
|
Build succeeded.
|
Contributor
Author
|
@dklyle @jrperritt this is ready for review for whenever someone has time. |
dklyle
approved these changes
Jan 16, 2018
Contributor
dklyle
left a comment
There was a problem hiding this comment.
Covers the API functionality, and the function renames are included. LGTM.
Contributor
Author
|
@dklyle Thanks! @jrperritt can you do a quick review when you have a moment? I don't want to jinx myself again by thinking it's good to go :) |
Contributor
|
Yes. I plan to go through all the open PRs today |
jrperritt
approved these changes
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #506
Code and reference is listed in #506