Skip to content

Do not specify go patch version#3645

Merged
stephenfin merged 1 commit intogophercloud:mainfrom
shiftstack:go-unspecify-patch
Mar 10, 2026
Merged

Do not specify go patch version#3645
stephenfin merged 1 commit intogophercloud:mainfrom
shiftstack:go-unspecify-patch

Conversation

@mandre
Copy link
Copy Markdown
Contributor

@mandre mandre commented Mar 10, 2026

There's no good reason for this, and makes it harder to consume.

There's no good reason for this, and makes it harder to consume.
@mandre mandre added the backport-v2 This PR will be backported to v2 label Mar 10, 2026
@github-actions github-actions bot added edit:dependencies This PR updates dependencies semver:major Breaking change and removed backport-v2 This PR will be backported to v2 labels Mar 10, 2026
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 63.856%. remained the same
when pulling 421f7d4 on shiftstack:go-unspecify-patch
into a83babe on gophercloud:main.

@mandre mandre added semver:patch No API change and removed semver:major Breaking change labels Mar 10, 2026
@mandre
Copy link
Copy Markdown
Contributor Author

mandre commented Mar 10, 2026

The semver job set it as major because it did not run properly due to GOTOOLCHAIN=local:

 ++ /home/runner/go/bin/go-apidiff a83babebedeea6ced66b9b468a507e53116f55f6 --compare-imports=false --print-compatible=true --repo-path=.
failed to get packages from old commit "a83babebedeea6ced66b9b468a507e53116f55f6" (a83babebedeea6ced66b9b468a507e53116f55f6): err: exit status 1: stderr: go: go.mod requires go >= 1.25.6 (running go 1.25.0; GOTOOLCHAIN=local)

This is just the tooling that failed (old commit had a higher minimum required version that was not met, and go refused to build due to GOTOOLCHAIN=local). This shouldn't be a problem in practice, since the the go directive indicates the minimum required version.

@mandre mandre added the backport-v2 This PR will be backported to v2 label Mar 10, 2026
@stephenfin stephenfin added this pull request to the merge queue Mar 10, 2026
Merged via the queue into gophercloud:main with commit 6e9ff80 Mar 10, 2026
72 checks passed
@stephenfin stephenfin deleted the go-unspecify-patch branch March 10, 2026 11:02
@github-actions
Copy link
Copy Markdown

Failed to backport PR to v2 branch. See logs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:dependencies This PR updates dependencies semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants