networking: extract port uplink status propagation into extension#3609
Open
kayrus wants to merge 1 commit intogophercloud:mainfrom
Open
networking: extract port uplink status propagation into extension#3609kayrus wants to merge 1 commit intogophercloud:mainfrom
kayrus wants to merge 1 commit intogophercloud:mainfrom
Conversation
850dfb6 to
f9a6b41
Compare
Contributor
Author
|
@mandre @stephenfin @EmilienM please review |
mandre
reviewed
Jan 28, 2026
Contributor
mandre
left a comment
There was a problem hiding this comment.
The code itself looks good.
A couple of small things:
- we should probably add a
doc.gofile for good measure. - I wished we had acceptance test covering
PropagateUplinkStatus. It would have clearly highlighted the breaking change.
How easy would it be to add those?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3605