Add support for name and description filters when listing Cinder volume types#3587
Conversation
Added fields: name, description, extra_specs Added tests
|
@Koodt thanks for your effort. Could you please add functional tests as well? |
|
Unfortunately due to added @mandre @stephenfin do you think we can make an exception? |
How about we split the PR in two, with all of the changes except for I'm always a little bit uncomfortable for making exceptions, because it creates a precedent, and also because we never know how people are using the lib. Thanks for the PR @Koodt. I recently had the same problem (https://github.com/k-orc/openstack-resource-controller/blob/b8d62d3cb3c4b56078228c4377aa9607161036d5/internal/controllers/volumetype/actuator.go#L75-L87) and didn't realize the API actually supported these fields because they're not documented in https://docs.openstack.org/api-ref/block-storage/v3/#list-all-volume-types but forgot that glance uses additional resource filters (https://docs.openstack.org/api-ref/block-storage/v3/#resource-filters-resource-filters). |
|
Hi! I've prepare the non-breaking changes for back port to v2 |
|
Failed to backport PR to |
This change adds support for additional server-side filters when listing Cinder volume types
The following filters are now supported:
• Filtering volume types by name
• Filtering volume types by description
Fixes #3586