Skip to content

network.v2.Port: add support for update mac_address#3578

Merged
mandre merged 1 commit intogophercloud:mainfrom
winiciusallan:update-mac-on-port
Dec 12, 2025
Merged

network.v2.Port: add support for update mac_address#3578
mandre merged 1 commit intogophercloud:mainfrom
winiciusallan:update-mac-on-port

Conversation

@winiciusallan
Copy link
Copy Markdown
Contributor

@winiciusallan winiciusallan commented Dec 12, 2025

Fixes #3499

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/api-ref/network/v2/index.html#update-port

@github-actions github-actions bot added edit:networking This PR updates networking code semver:major Breaking change labels Dec 12, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 12, 2025

Coverage Status

coverage: 63.756%. remained the same
when pulling 9b8dcd5 on winiciusallan:update-mac-on-port
into b97ec1d on gophercloud:main.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Dec 12, 2025

The incompatibles changes are limited to testing, we should be able to backport it to v2.

github.com/gophercloud/gophercloud/v2/openstack/networking/v2/ports/testing
  Incompatible changes:
  - UpdateRequest: value changed from "\n{\n    \"port\": {\n        \"name\": \"new_port_name\",\n        ... to "\n{\n    \"port\": {\n        \"name\": \"new_port_name\",\n        ...
  - UpdateResponse: value changed from "\n{\n    \"port\": {\n        \"status\": \"DOWN\",\n        \"name\... to "\n{\n    \"port\": {\n        \"status\": \"DOWN\",\n        \"name\...

github.com/gophercloud/gophercloud/v2/openstack/networking/v2/ports
  Compatible changes:
  - UpdateOpts.MACAddress: added'

@mandre mandre added semver:minor Backwards-compatible change and removed semver:major Breaking change labels Dec 12, 2025
@mandre mandre added the backport-v2 This PR will be backported to v2 label Dec 12, 2025
@mandre
Copy link
Copy Markdown
Contributor

mandre commented Dec 12, 2025

Looks like the functional-networking job is broken because neutron-dynamic-routing still uses eventlet. I believe we'll need https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/956747.

@mandre mandre added this pull request to the merge queue Dec 12, 2025
Merged via the queue into gophercloud:main with commit 487e09e Dec 12, 2025
70 of 72 checks passed
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Dec 12, 2025
Merged
@winiciusallan winiciusallan deleted the update-mac-on-port branch December 16, 2025 12:06
@winiciusallan winiciusallan mentioned this pull request Dec 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes

Assignees

No one assigned

Labels

backport-v2 This PR will be backported to v2 edit:networking This PR updates networking code semver:minor Backwards-compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

neutron: add an ability to update port mac_address

3 participants

@winiciusallan @coveralls @mandre