Skip to content

identity/services: add omitempty to the type field#3554

Merged
mandre merged 1 commit intogophercloud:mainfrom
winiciusallan:change-service-type
Nov 17, 2025
Merged

identity/services: add omitempty to the type field#3554
mandre merged 1 commit intogophercloud:mainfrom
winiciusallan:change-service-type

Conversation

@winiciusallan
Copy link
Copy Markdown
Contributor

Fixes #3553

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://docs.openstack.org/api-ref/identity/v3/index.html#update-service

@github-actions github-actions bot added edit:identity This PR updates identity code semver:patch No API change backport-v2 This PR will be backported to v2 labels Nov 14, 2025
@winiciusallan
Copy link
Copy Markdown
Contributor Author

cc. @mandre

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 14, 2025

Coverage Status

coverage: 63.813%. remained the same
when pulling 47c5691 on winiciusallan:change-service-type
into 5fc8537 on gophercloud:main.

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll just need #3556 first to unblock the gate.

@winiciusallan
Copy link
Copy Markdown
Contributor Author

We'll just need #3556 first to unblock the gate.

Could you please rerun the jobs?

@mandre mandre force-pushed the change-service-type branch from 0442a28 to 47c5691 Compare November 17, 2025 12:51
@mandre
Copy link
Copy Markdown
Contributor

mandre commented Nov 17, 2025

We'll just need #3556 first to unblock the gate.

Could you please rerun the jobs?

We needed to rebase the change (to pick up the fixes for the tests) which I just did.

@mandre mandre enabled auto-merge November 17, 2025 12:52
@mandre mandre added this pull request to the merge queue Nov 17, 2025
Merged via the queue into gophercloud:main with commit da05fe1 Nov 17, 2025
62 checks passed
@winiciusallan winiciusallan deleted the change-service-type branch December 16, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:identity This PR updates identity code semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

service.UpdateOpts always generates Type as an empty value

3 participants