Skip to content

Enable deletion for network and loadbalancer quotas#3518

Merged
mandre merged 3 commits intogophercloud:mainfrom
MaximilianMeister:quota-delete-net-lb
Oct 1, 2025
Merged

Enable deletion for network and loadbalancer quotas#3518
mandre merged 3 commits intogophercloud:mainfrom
MaximilianMeister:quota-delete-net-lb

Conversation

@MaximilianMeister
Copy link
Copy Markdown
Contributor

@MaximilianMeister MaximilianMeister commented Sep 24, 2025 •
edited
Loading

Fixes #3517

  • tested in openstack environment

@github-actions github-actions bot added edit:networking This PR updates networking code edit:loadbalancer This PR updates loadbalancer code semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Sep 24, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 30, 2025 •
edited
Loading

Coverage Status

coverage: 63.823% (+0.02%) from 63.808%
when pulling a108557 on MaximilianMeister:quota-delete-net-lb
into 9abafd1 on gophercloud:main.

mandre
mandre reviewed Sep 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code addition looks good, could you just add a call to the new Delete() functions in the acceptance tests to validate it effectively works on the versions of OpenStack that we support?

@MaximilianMeister
Copy link
Copy Markdown
Contributor Author

MaximilianMeister commented Oct 1, 2025

The code addition looks good, could you just add a call to the new Delete() functions in the acceptance tests to validate it effectively works on the versions of OpenStack that we support?

@mandre sure! thanks for the review and the hint. I added the missing API calls to the acceptance tests and also added a note to the acceptance testing docs.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Oct 1, 2025

Perfect, thanks a lot! Thanks also for updating the contributors docs. I'll just wait for CI to come back before approving and merging your changes.

@mandre
Copy link
Copy Markdown
Contributor

mandre commented Oct 1, 2025

Actually, we've recently enabled merge queue on this repository so I can approve directly. If the CI fails, it should not merge the patch. Let's see.

@mandre mandre enabled auto-merge October 1, 2025 06:43
@mandre mandre added this pull request to the merge queue Oct 1, 2025
Merged via the queue into gophercloud:main with commit 3008470 Oct 1, 2025
79 of 80 checks passed
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Oct 1, 2025
Merged
1 task
@MaximilianMeister MaximilianMeister deleted the quota-delete-net-lb branch October 4, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes

Assignees

No one assigned

Labels

backport-v2 This PR will be backported to v2 edit:loadbalancer This PR updates loadbalancer code edit:networking This PR updates networking code semver:minor Backwards-compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable quota deletion for network and loadbalancer quotas

3 participants

@MaximilianMeister @coveralls @mandre