Closes #2321 - Fix TestRolesCRUD by including DomainID to TestRolesCRUD #3509
Merged
stephenfin merged 1 commit intogophercloud:mainfrom Sep 17, 2025
Merged
Conversation
…CreateOpts/ListOps structs. Signed-off-by: Dan Lawton <dlawton@redhat.com>
stephenfin
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #[2321]
The original issue said that Gophercloud did not support deleting roles from a specific domain. This isn't really the case as to create a role, a domain must be specified also. The API allows deletion by role ID without specifying a domain,but this is fine as the role ID is all that is needed for the role to be deleted from a specific domain.
API call refs
To make the Acceptance test consistent with this API behaviour, "DomainID" was added to both calls CreateOpts & ListOpts in roles_test.go.
So going to close this issue as no new feature needed because Delete Role works as expected.