core: clone service type aliases instead of referencing global slice#3462
Merged
stephenfin merged 1 commit intogophercloud:mainfrom Jul 21, 2025
Merged
core: clone service type aliases instead of referencing global slice#3462stephenfin merged 1 commit intogophercloud:mainfrom
stephenfin merged 1 commit intogophercloud:mainfrom
Conversation
This was referenced Jul 16, 2025
Merged
stephenfin
approved these changes
Jul 21, 2025
Contributor
|
This should go on top of #3435 once merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix modifying the
eo.Aliasescauses the modification of the global map slice entry.We might need to enable linter that catches this.
UPD: gocritic doesn't catch this case :(