Fix pagination for messaging client#3456
Merged
stephenfin merged 2 commits intogophercloud:mainfrom Jul 15, 2025
Merged
Conversation
Zaqar returns paths rather than URLs in 'links' response fields and the
'Location' header. In addition, since Dalmatian, it deploys under a path
('/messaging') rather then behind a port. This combination has
highlighted a bug in our pagination page handling, namely that we are
ignoring the path element of the endpoint URL. While this is not an
issue when the 'next' link is an absolute URL, as with most other
services, it results in incomplete URLs when the link URL is relative
('/v2/messages') and the endpoint URL contains a path
('https://example.com/messaging').
Fix this by concatenating the two paths, rather than overwriting the
endpoint URLs path.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
EmilienM
previously approved these changes
Jul 15, 2025
As a regression test. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
kayrus
approved these changes
Jul 15, 2025
|
Failed to backport PR to |
This was referenced Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3336
Zaqar returns paths rather than URLs in
linksresponse fields and theLocationheader. In addition, since Dalmatian, it deploys under a path (/messaging) rather then behind a port. This combination has highlighted a bug in our pagination page handling, namely that we are ignoring the path element of the endpoint URL. While this is not an issue when thenextlink is an absolute URL, as with most other services, it results in incomplete URLs when the link URL is relative (/v2/messages) and the endpoint URL contains a path (https://example.com/messaging).Fix this by concatenating the two paths, rather than overwriting the endpoint URLs path.