Open
Conversation
This was referenced Jul 16, 2025
Merged
stephenfin
reviewed
Aug 11, 2025
Comment on lines
+86
to
+92
| HA *bool `json:"ha,omitempty"` | ||
| ServiceTypeID string `json:"service_type_id,omitempty"` | ||
| FlavorID string `json:"flavor_id,omitempty"` | ||
| EnableNDPProxy *bool `json:"enable_ndp_proxy,omitempty"` | ||
| EnableDefaultRouteBFD *bool `json:"enable_default_route_bfd,omitempty"` | ||
| EnableDefaultRouteECMP *bool `json:"enable_default_route_ecmp,omitempty"` | ||
| GatewayInfo *GatewayInfo `json:"external_gateway_info,omitempty"` |
Contributor
There was a problem hiding this comment.
Could you separate these and call out the extensions that add them? Alternatively, could we add a new struct tag that would allow us to e.g. check if an extension is enabled before sending/attemtpting to retrieve a field?
Contributor
This is a fair point. I've said this inline, but I wonder if we could streamline things via a custom struct tag? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new extension fields. Not sure if to put them as separate extensions, since other extension fields like
distributedoravailability_zone_hintswere already implemented directly inside the routers package.Likewise in #3424, if user doesn't specify these parameters, they won't be sent to API. Therefore from my perspective it is safe to keep them here, otherwise the consumer code complexity will be increased.