Fix documentation for gateway_ip in subnet update#3421
Merged
pierreprinetti merged 1 commit intogophercloud:mainfrom Jun 12, 2025
Merged
Fix documentation for gateway_ip in subnet update#3421pierreprinetti merged 1 commit intogophercloud:mainfrom
pierreprinetti merged 1 commit intogophercloud:mainfrom
Conversation
stephenfin
previously approved these changes
Jun 12, 2025
Contributor
stephenfin
left a comment
There was a problem hiding this comment.
CI failures are unrelated so this lgtm
The neutron documentation was wrong, and not providing a gateway_ip is a no-op for subnet update. Neutron docs being fixed at [1]. [1] https://review.opendev.org/c/openstack/neutron-lib/+/952428
61a6a36 to
e8982ca
Compare
pierreprinetti
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The neutron documentation was wrong, and not providing a gateway_ip is a no-op for subnet update.
Neutron docs being fixed at [1].
[1] https://review.opendev.org/c/openstack/neutron-lib/+/952428