dns: implement shared zones list#3390
Merged
EmilienM merged 1 commit intogophercloud:mainfrom May 22, 2025
Merged
Conversation
Contributor
Author
|
I'm removing |
|
Failed to assess the semver bump. See logs for details. |
dc05078 to
fd91aa8
Compare
|
Failed to assess the semver bump. See logs for details. |
|
Failed to assess the semver bump. See logs for details. |
EmilienM
reviewed
May 22, 2025
EmilienM
previously approved these changes
May 22, 2025
Contributor
EmilienM
left a comment
There was a problem hiding this comment.
LGTM, minor suggestion feel free to skip it and merge.
EmilienM
approved these changes
May 22, 2025
|
Labels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3048
This PR adds zone share list and proper body read in the
Sharefunc. Previously this call leaked request bodies, because the response was not read.Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://docs.openstack.org/api-ref/dns/dns-api-v2-index.html#get-all-shared-zones