Skip to content

tests: Fix TestBGPAgentCRUD#3382

Merged
stephenfin merged 2 commits intogophercloud:mainfrom
shiftstack:issues/3380
May 16, 2025
Merged

tests: Fix TestBGPAgentCRUD#3382
stephenfin merged 2 commits intogophercloud:mainfrom
shiftstack:issues/3380

Conversation

@stephenfin
Copy link
Copy Markdown
Contributor

@stephenfin stephenfin commented May 14, 2025

  • Revert "[tests]: increase timeout for the TestBGPAgentRUD test"
  • tests: Fix TestBGPAgentCRUD

@stephenfin
Revert "[tests]: increase timeout for the TestBGPAgentRUD test"
c295505 
This reverts commit 2de734a. It didn't
help and an actual fix is needed.

Conflicts:
    internal/acceptance/openstack/networking/v2/extensions/agents/agents_test.go

NOTE(stephenfin): Conflicts are due to us renaming the test in commit
148e43a.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@github-actions github-actions bot added edit:networking This PR updates networking code edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code semver:patch No API change labels May 14, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented May 14, 2025 •
edited
Loading

Coverage Status

coverage: 63.828%. remained the same
when pulling 669a870 on shiftstack:issues/3380
into 8319ad1 on gophercloud:main.

@stephenfin
tests: Fix TestBGPAgentCRUD
669a870 
Change our deployment so that we use the static scheduler, and rework
the test to handle this. Instead of waiting for the speaker to be
associated with an agent (which won't happen with the static scheduler)
we now jump straight to assigning it.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes: gophercloud#3380
kayrus
kayrus approved these changes May 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stephenfin stephenfin merged commit 37187ac into gophercloud:main May 16, 2025
19 checks passed
@stephenfin stephenfin deleted the issues/3380 branch May 16, 2025 11:10
@stephenfin stephenfin added the backport-v2 This PR will be backported to v2 label May 16, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 16, 2025

Failed to backport PR to v2 branch. See logs for details.

@stephenfin stephenfin mentioned this pull request May 16, 2025
Merged
@mandre mandre mentioned this pull request Jun 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kayrus kayrus kayrus approved these changes

Assignees

No one assigned

Labels

backport-v2 This PR will be backported to v2 edit:actions This PR updates GitHub Actions code edit:networking This PR updates networking code edit:testinfra This PR updates testing infrastructure code semver:patch No API change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenfin @coveralls @kayrus