Skip to content

Run functional tests if workflow changes#3377

Merged
stephenfin merged 7 commits intogophercloud:mainfrom
shiftstack:self-testing-functional
May 14, 2025
Merged

Run functional tests if workflow changes#3377
stephenfin merged 7 commits intogophercloud:mainfrom
shiftstack:self-testing-functional

Conversation

@stephenfin
Copy link
Copy Markdown
Contributor

@stephenfin stephenfin commented May 13, 2025

Per $subject.

@github-actions github-actions bot added edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code semver:patch No API change labels May 13, 2025
@stephenfin
Copy link
Copy Markdown
Contributor Author

stephenfin commented May 13, 2025 •
edited
Loading

Well that didn't work...

Fixed. Wasn't to do with this PR.

@coveralls
Copy link
Copy Markdown

coveralls commented May 13, 2025 •
edited
Loading

Coverage Status

coverage: 63.828% (+0.008%) from 63.82%
when pulling 13997f3 on shiftstack:self-testing-functional
into 5631f7c on gophercloud:main.

@stephenfin stephenfin force-pushed the self-testing-functional branch from 15b9053 to e9b44bc Compare May 13, 2025 16:33
stephenfin added 2 commits May 13, 2025 17:34
@stephenfin
Replace errant character in workflows
7c10efb 
It's annoying that GitHub doesn't surface this error.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Fixes: c4a191e
@stephenfin
Run functional tests if workflow changes
69b5446 
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin stephenfin force-pushed the self-testing-functional branch from e9b44bc to 69b5446 Compare May 13, 2025 16:35
@stephenfin stephenfin mentioned this pull request May 13, 2025
Merged
@stephenfin
Copy link
Copy Markdown
Contributor Author

stephenfin commented May 13, 2025

@kayrus I'm waiting on the last two compute tests to come back but I think this can merge as-is.

stephenfin added 2 commits May 13, 2025 18:31
@stephenfin
tests: Devolve acceptance test conditions
2a22f9d 
Place service-specific conditions in service-specific locations.

We also removed the now-unused RequireNovaNetwork helper.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
tests: Skip vpnaas tests if extension missing
8314ff1 
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@github-actions github-actions bot added edit:networking This PR updates networking code edit:compute This PR updates compute code edit:sharedfilesystems This PR updates sharedfilesystems code edit:baremetal This PR updates baremetal code edit:blockstorage This PR updates blockstorage code edit:identity This PR updates identity code labels May 13, 2025
@stephenfin
Copy link
Copy Markdown
Contributor Author

stephenfin commented May 13, 2025

  • functional-fwaas_v2 tests are failing because they are attempting to run vpnaas tests but are not installing the package. That needs a separate fix that we can do elsewhere.

Add the fixes for this.

@kayrus
Copy link
Copy Markdown
Contributor

kayrus commented May 13, 2025

Caracal fails due to wrong v1 manila endpoint picked up from the catalog.

@stephenfin
Copy link
Copy Markdown
Contributor Author

stephenfin commented May 14, 2025 •
edited
Loading

Caracal fails due to wrong v1 manila endpoint picked up from the catalog.

Yup. Per above:

I don't plan to fix that here. We have 2 (3?) other PRs open for that.

@stephenfin
Copy link
Copy Markdown
Contributor Author

stephenfin commented May 14, 2025

  • functional-fwaas_v2 tests are failing because they are attempting to run vpnaas tests but are not installing the package. That needs a separate fix that we can do elsewhere.

Add the fixes for this.

Looks like I need more fixes here. I'm working on it.

stephenfin added 3 commits May 14, 2025 10:22
@stephenfin
tests: Configure policy in fwaas functional workflow
df9032a 
We already do this for the networking workflow. Now do it for the
fwaas-specific workflow.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
tests: Skip bgp tests if extension missing
148e43a 
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
tests: Skip bgpvpn tests if extension missing
13997f3 
We also fix some typos in test names.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin stephenfin mentioned this pull request May 14, 2025
Merged
@stephenfin
Copy link
Copy Markdown
Contributor Author

stephenfin commented May 14, 2025

@kayrus I think this is good to go. I'll rebase #3368 once it's in.

@kayrus kayrus added the backport-v2 This PR will be backported to v2 label May 14, 2025
@stephenfin stephenfin merged commit 8319ad1 into gophercloud:main May 14, 2025
64 of 67 checks passed
@stephenfin stephenfin deleted the self-testing-functional branch May 14, 2025 12:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 14, 2025

Failed to backport PR to v2 branch. See logs for details.

@stephenfin stephenfin mentioned this pull request May 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kayrus kayrus kayrus approved these changes

Assignees

No one assigned

Labels

backport-v2 This PR will be backported to v2 edit:actions This PR updates GitHub Actions code edit:baremetal This PR updates baremetal code edit:blockstorage This PR updates blockstorage code edit:compute This PR updates compute code edit:identity This PR updates identity code edit:networking This PR updates networking code edit:sharedfilesystems This PR updates sharedfilesystems code edit:testinfra This PR updates testing infrastructure code semver:patch No API change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenfin @coveralls @kayrus