Skip to content

[v2] core: add missing Builder interfaces#3375

Merged
kayrus merged 1 commit intogophercloud:v2from
kayrus:opts-builder-v2
May 13, 2025
Merged

[v2] core: add missing Builder interfaces#3375
kayrus merged 1 commit intogophercloud:v2from
kayrus:opts-builder-v2

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented May 12, 2025

Manual cherry-pick of the #3363 PR

@github-actions github-actions bot added edit:networking This PR updates networking code edit:loadbalancer This PR updates loadbalancer code edit:compute This PR updates compute code v2 This PR targets v2 edit:sharedfilesystems This PR updates sharedfilesystems code edit:blockstorage This PR updates blockstorage code edit:identity This PR updates identity code labels May 12, 2025
@github-actions github-actions bot added the semver:major Breaking change label May 12, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented May 12, 2025 •
edited
Loading

Coverage Status

coverage: 78.612% (-0.006%) from 78.618%
when pulling 6b0ebdc on kayrus:opts-builder-v2
into 7177265 on gophercloud:v2.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented May 12, 2025

@stephenfin @pierreprinetti @mandre @EmilienM
Despite modifying function signatures, this PR can be backported to v2 since it adds an interface type and compatible with opts.

@kayrus kayrus force-pushed the opts-builder-v2 branch from 0538f51 to 6b0ebdc Compare May 13, 2025 16:50
@kayrus kayrus changed the title core: add missing Builder interfaces [v2] core: add missing Builder interfaces May 13, 2025
@stephenfin
Copy link
Copy Markdown
Contributor

stephenfin commented May 13, 2025

Just be aware that none of the functional jobs are currently working due to #3376 (review) We might want to wait for the fix then rebase this again.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented May 13, 2025

@stephenfin I'm taking the responsibility. The initial #3363 PR was fine.

@kayrus kayrus merged commit d819c3f into gophercloud:v2 May 13, 2025
10 checks passed
@kayrus kayrus deleted the opts-builder-v2 branch May 13, 2025 18:47
@stephenfin stephenfin mentioned this pull request May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenfin stephenfin stephenfin approved these changes

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

No one assigned

Labels

edit:blockstorage This PR updates blockstorage code edit:compute This PR updates compute code edit:identity This PR updates identity code edit:loadbalancer This PR updates loadbalancer code edit:networking This PR updates networking code edit:sharedfilesystems This PR updates sharedfilesystems code semver:major Breaking change v2 This PR targets v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kayrus @coveralls @stephenfin