Skip to content

octavia: fix http_version type to float#3356

Merged
mandre merged 1 commit intogophercloud:mainfrom
kayrus:http-version
Apr 30, 2025
Merged

octavia: fix http_version type to float#3356
mandre merged 1 commit intogophercloud:mainfrom
kayrus:http-version

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Apr 28, 2025

Fixes #3355

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

[PUT URLS HERE]

@github-actions github-actions bot added edit:loadbalancer This PR updates loadbalancer code semver:minor Backwards-compatible change labels Apr 28, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 28, 2025

Coverage Status

coverage: 78.68% (-0.01%) from 78.691%
when pulling 9337a4f on kayrus:http-version
into 1906146 on gophercloud:main.

@pierreprinetti
Copy link
Copy Markdown
Member

/hold
Discussion in #3355

@pierreprinetti pierreprinetti added the hold Do not merge label Apr 28, 2025
@pierreprinetti
Copy link
Copy Markdown
Member

On a second thought I'm going to remove the hold because it makes no sense for me to block anything here.

@pierreprinetti pierreprinetti removed the hold Do not merge label Apr 29, 2025
@github-actions github-actions bot added edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code labels Apr 29, 2025
@kayrus kayrus force-pushed the http-version branch 8 times, most recently from c315af4 to 9d19094 Compare April 29, 2025 15:31
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Apr 30, 2025

@pierreprinetti @mandre I fixed the devstack master tests, can you approve the PR?
P.S. This hack can be used for other services, which haven't yet migrated to uwsgi module path.
see https://bugs.launchpad.net/devstack/+bug/2109604

mandre
mandre previously approved these changes Apr 30, 2025
@kayrus kayrus added the backport-v2 This PR will be backported to v2 label Apr 30, 2025
@mandre mandre merged commit 92815d1 into gophercloud:main Apr 30, 2025
18 checks passed
@kayrus kayrus deleted the http-version branch April 30, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:actions This PR updates GitHub Actions code edit:loadbalancer This PR updates loadbalancer code edit:testinfra This PR updates testing infrastructure code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

octavia: http_version monitor field must have float type

4 participants