[v2] Improve support for network standard-attr-* extensions#3319
Closed
gophercloud-backport-bot[bot] wants to merge 2 commits intov2from
Closed
[v2] Improve support for network standard-attr-* extensions#3319gophercloud-backport-bot[bot] wants to merge 2 commits intov2from
standard-attr-* extensions#3319gophercloud-backport-bot[bot] wants to merge 2 commits intov2from
Conversation
Consistently add support for the neutron `Resource revision numbers` extension [1] for more resources that support it. It adds a `RevisionNumber` field to all responses, and allows filtering via the `RevisionNumber` list option. It was only partially implemented. Also support the `If-Match` constraints, and add test for it. [1] https://docs.openstack.org/api-ref/network/v2/#revisions
Add a few missing `CreatedAt` and `UpdatedAt` fields for networking resources.
Contributor
|
@mandre unit tests seem to fail 😕 |
Contributor
|
This appears to break neutron in bobcat that returns a 500 error: |
Contributor
|
Bobcat should be supported until end of April at least, so I reported the bug upstream at https://bugs.launchpad.net/neutron/+bug/2101871. We should skip this test on bobcat. |
Contributor
|
Closing in favor of #3328. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #3318
Consistently add support for the neutron
Resource revision numbersextension [1] for more resources that support it. It adds
a
RevisionNumberfield to all responses, and allows filtering via theRevisionNumberlist option. It was only partially implemented.Support the
If-Matchconstraints for these resources, and add test for it.Add a few missing
CreatedAtandUpdatedAtfields for networkingresources.
[1] https://docs.openstack.org/api-ref/network/v2/#revisions