Enhance Snapshot struct and add ListDetail function in V3 blockstorage#3305
Merged
mandre merged 1 commit intogophercloud:mainfrom Mar 15, 2025
Merged
Enhance Snapshot struct and add ListDetail function in V3 blockstorage#3305mandre merged 1 commit intogophercloud:mainfrom
mandre merged 1 commit intogophercloud:mainfrom
Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
mandre
reviewed
Mar 6, 2025
Contributor
mandre
left a comment
There was a problem hiding this comment.
This looks great. We can merge after you address the missing assert and squash your commits.
| @@ -74,6 +74,23 @@ func TestSnapshots(t *testing.T) { | |||
| return true, nil | |||
| }) | |||
|
|
|||
Contributor
There was a problem hiding this comment.
We're missing an th.AssertNoErr(t, err) here, to validate that the previous call didn't return an error.
Author
There was a problem hiding this comment.
Added the missing line of code and squashed my commits
- Extended Snapshot struct to include additional fields: Progress, ProjectID, GroupSnapshotID, UserID, ConsumesQuota - Implemented ListDetail function to retrieve detailed snapshot information from the snapshots/detail endpoint - Added new test to validate the inclusion of additional fields and the functionality of the ListDetails function Fixes: gophercloud#2403
mandre
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2403
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
Documentation: https://docs.openstack.org/api-ref/block-storage/v3/#list-snapshots-and-details