bulk security group rule creation: Allow using CreateOptsBuilder#3276
Merged
EmilienM merged 1 commit intogophercloud:masterfrom Dec 22, 2024
Merged
bulk security group rule creation: Allow using CreateOptsBuilder#3276EmilienM merged 1 commit intogophercloud:masterfrom
EmilienM merged 1 commit intogophercloud:masterfrom
Conversation
Before this patch, security group rules could only be created in a batch when using slices of plain `rules.CreateOpts`. With this change, a slice of any type implementing `rules.CreateOptsBuilder` can be used to create security group rules in a batch.
mandre
previously approved these changes
Dec 20, 2024
Member
Author
|
There may be a race condition in the tests |
be5df0d to
c3046b1
Compare
EmilienM
approved these changes
Dec 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, security group rules could only be created in a batch when using slices of plain
rules.CreateOpts. With this change, a slice of any type implementingrules.CreateOptsBuildercan be used to create security group rules in a batch.