Address govet 1.24 issue#3241
Merged
pierreprinetti merged 3 commits intogophercloud:masterfrom Dec 2, 2024
Merged
Conversation
EmilienM
previously approved these changes
Nov 28, 2024
1cacca8 to
bcbeda5
Compare
Contributor
Author
|
Turned out (a) there were two additional legitimate users of |
de08649 to
b1c3fe4
Compare
We really need to run golangci-lint in the gate but fix these issues for now. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We were incorrectly using 'fmt.Printf', 'fmt.Errorf' and 't.Logf' with non-template strings/no arguments. The fix to this is replace these calls with the non-suffixed variants. There are many users of 'fmt.Fprint' - too many to do by hand - so this replacement was resolved using 'sed': sed 's/Fprintf/Fprint/g' -i $(ag fmt.Fprintf -l) We then manually fix the 25 cases where 'fmt.Fprintf' is actually warranted and manually replaced the errant users of 'fmt.Errorf' and 't.Logf'. We also rework 'internal/acceptance/clients/clients.go' slightly to make the code a bit clearer. PS: This is apparently going to be an issue in go 1.24 (specifically in 'go vet') [1] so this is not just golangci-lint being annoying. @pierreprinetti, that's directed at you ;) [1] golang/go#60529 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We also add the '-v' and '--max-same-issues' flags so that we get some indication that things are running and show more output. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
b1c3fe4 to
0d4b68d
Compare
pierreprinetti
approved these changes
Dec 2, 2024
|
Failed to backport PR to |
|
Failed to backport PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump golangci-lint, which highlights issues that we will see with go vet 1.24.
Depends-on: #3242
Commits
lint: Address recent lint issueslint: Remove non-constant format string in calls (govet)make: Bump golangci-lint