Added required fields for Node API Parity#3228
Merged
EmilienM merged 1 commit intogophercloud:masterfrom Nov 20, 2024
Merged
Conversation
EmilienM
reviewed
Nov 20, 2024
EmilienM
reviewed
Nov 20, 2024
EmilienM
reviewed
Nov 20, 2024
Contributor
|
also please squash |
Contributor
|
I tagged it for a v2 backport candidate since I'm sure you'll need that downstream. |
04506e2 to
3d2bb51
Compare
Contributor
Author
|
That should be it. Merci :)) |
Contributor
|
@Sharpz7 squash it please |
Contributor
Author
|
@EmilienM I think I have? its a single commit? |
EmilienM
approved these changes
Nov 20, 2024
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3172
I have 1-1 mapped with: https://docs.openstack.org/api-ref/baremetal/#list-nodes-detailed
=========================
Since all the fields I have added were already present in the test fixtures, this was an easy change!