Skip to content

docs: Remove outdated godoc#3217

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
shiftstack:update_docs
Oct 17, 2024
Merged

docs: Remove outdated godoc#3217
EmilienM merged 1 commit intogophercloud:masterfrom
shiftstack:update_docs

Conversation

@pierreprinetti
Copy link
Copy Markdown
Member

@pierreprinetti pierreprinetti commented Oct 17, 2024

The doc.go file, and go.dev as a consequence, was still recommending to use utils for authentication.

Since the automatically-generated documentation on the Go website already includes the README, we can delete doc.go and keep README.md as the canonical introduction to the module.

Fixes #3216

@pierreprinetti pierreprinetti requested a review from a team October 17, 2024 09:44
@github-actions github-actions bot added edit:gophercloud This PR updates common Gophercloud code semver:patch No API change labels Oct 17, 2024
@pierreprinetti pierreprinetti added the backport-v2 This PR will be backported to v2 label Oct 17, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 17, 2024

Coverage Status

coverage: 78.726%. remained the same
when pulling 3966ef3 on shiftstack:update_docs
into c332e3e on gophercloud:master.

@pierreprinetti
Copy link
Copy Markdown
Member Author

pierreprinetti commented Oct 17, 2024

Wait. Is the godoc page really including the README already?

I am updating this PR to just delete doc.go. I am also changing its title and description.

@pierreprinetti pierreprinetti marked this pull request as draft October 17, 2024 09:53
@pierreprinetti pierreprinetti changed the title docs: Update godoc to match README docs: Remove outdated godoc Oct 17, 2024
@pierreprinetti pierreprinetti marked this pull request as ready for review October 17, 2024 09:58
The `doc.go` file, and
[go.dev](https://pkg.go.dev/github.com/gophercloud/gophercloud/v2) as a
consequence, was still recommending to use utils for authentication.

Since the automatically-generated documentation on the Go website
already includes the README, we can delete doc.go and keep README.md as
the canonical introduction to the module.
@EmilienM EmilienM merged commit 22fe3c1 into gophercloud:master Oct 17, 2024
@EmilienM EmilienM deleted the update_docs branch October 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:gophercloud This PR updates common Gophercloud code semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should clientconfig be used?

3 participants