[manila] add scheduler_hints to the shares CreateOpts#3211
Merged
pierreprinetti merged 1 commit intogophercloud:masterfrom Oct 16, 2024
Merged
[manila] add scheduler_hints to the shares CreateOpts#3211pierreprinetti merged 1 commit intogophercloud:masterfrom
pierreprinetti merged 1 commit intogophercloud:masterfrom
Conversation
3c0c8e2 to
2b109d7
Compare
Contributor
Author
|
@pierreprinetti @mdbooth @EmilienM kindly ping |
mdbooth
reviewed
Oct 16, 2024
Contributor
mdbooth
left a comment
There was a problem hiding this comment.
Marshalling looks correct to me.
/lgtm
| AvailabilityZone string `json:"availability_zone,omitempty"` | ||
| // SchedulerHints are hints for the scheduler to select the share backend | ||
| // Only available in and beyond API version 2.65 | ||
| SchedulerHints *SchedulerHints `json:"scheduler_hints,omitempty"` |
Contributor
There was a problem hiding this comment.
|
|
||
| // SchedulerHints contains options for providing scheduler hints when creating | ||
| // a Share. | ||
| type SchedulerHints struct { |
Contributor
There was a problem hiding this comment.
pierreprinetti
approved these changes
Oct 16, 2024
Member
pierreprinetti
left a comment
There was a problem hiding this comment.
Thank you! (and thank you @mdbooth for the review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3204