[manila] add share_group_id to share's CreateOpts#3205
Merged
kayrus merged 1 commit intogophercloud:masterfrom Oct 16, 2024
Merged
[manila] add share_group_id to share's CreateOpts#3205kayrus merged 1 commit intogophercloud:masterfrom
kayrus merged 1 commit intogophercloud:masterfrom
Conversation
EmilienM
previously approved these changes
Oct 9, 2024
Contributor
Author
|
@EmilienM can you approve this? |
d0050f9 to
f8007ee
Compare
Contributor
Author
|
@pierreprinetti @mdbooth @EmilienM kindly ping |
mdbooth
reviewed
Oct 16, 2024
Contributor
mdbooth
left a comment
There was a problem hiding this comment.
Marshalling looks correct. Does this need tests?
/lgtm
| // Determines whether or not the share is public | ||
| IsPublic *bool `json:"is_public,omitempty"` | ||
| // The UUID of the share group. Available starting from the microversion 2.31 | ||
| ShareGroupID string `json:"share_group_id,omitempty"` |
Contributor
There was a problem hiding this comment.
| // The name of the share type. | ||
| ShareTypeName string `json:"share_type_name"` | ||
| // The UUID of the share group. Available starting from the microversion 2.31 | ||
| ShareGroupID string `json:"share_group_id"` |
Contributor
There was a problem hiding this comment.
Contributor
Author
in order to have tests we need to implement a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes the #3204