Skip to content

octavia: add new security options to pools and listeners#3178

Merged
EmilienM merged 2 commits intogophercloud:masterfrom
kayrus:lb-security
Sep 24, 2024
Merged

octavia: add new security options to pools and listeners#3178
EmilienM merged 2 commits intogophercloud:masterfrom
kayrus:lb-security

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Sep 23, 2024

Fixes #3177

@kayrus kayrus requested a review from a team September 23, 2024 21:01
@github-actions github-actions bot added edit:loadbalancer This PR updates loadbalancer code semver:minor Backwards-compatible change labels Sep 23, 2024
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 23, 2024 •
edited
Loading

Coverage Status

coverage: 78.716% (-0.03%) from 78.741%
when pulling 90c1d82 on kayrus:lb-security
into 18e5f3b on gophercloud:master.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Sep 23, 2024

is it possible to have tests? (unit & functional) if we have existing ones already?

@kayrus kayrus mentioned this pull request Sep 24, 2024
Merged
mandre
mandre approved these changes Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let @EmilienM merge if he's fine with this not having additional tests.

@mandre mandre added the backport-v2 This PR will be backported to v2 label Sep 24, 2024
@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Sep 24, 2024

@mandre I'm testing some corner cases, like nulling the parameters in terraform-provider-openstack/terraform-provider-openstack#1785. Please hold on with the merge. Probably I'll add some functional tests to ensure that parameters can be removed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Sep 24, 2024

I just realized that adding functional tests to pools and listeners requires much more work than I expected. Currently there is only list check. I covered new options in terraform functional tests in terraform env, I hope this would be enough.

As for the gophercloud octavia functional tests, I'd create a new issue to extend the pool and listener tests with CRUD.

@EmilienM
Copy link
Copy Markdown
Contributor

EmilienM commented Sep 24, 2024

@kayrus so you're saying this is ready to go now?

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Sep 24, 2024

@EmilienM yes

@EmilienM EmilienM merged commit faa8108 into gophercloud:master Sep 24, 2024
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Sep 24, 2024
Merged
@kayrus kayrus deleted the lb-security branch September 24, 2024 15:32
This was referenced Sep 24, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes

Assignees

No one assigned

Labels

backport-v2 This PR will be backported to v2 edit:loadbalancer This PR updates loadbalancer code semver:minor Backwards-compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

octavia: add new security options to pools and listeners

4 participants

@kayrus @coveralls @EmilienM @mandre