Skip to content

Small improvements to v2 migration script#3171

Merged
EmilienM merged 2 commits intogophercloud:masterfrom
shiftstack:migration-script-improvements
Sep 11, 2024
Merged

Small improvements to v2 migration script#3171
EmilienM merged 2 commits intogophercloud:masterfrom
shiftstack:migration-script-improvements

Conversation

@mandre
Copy link
Copy Markdown
Contributor

@mandre mandre commented Sep 11, 2024

These are a couple of small improvements to the automated v2 migration script:

  • exclude vendor directory
  • try converting all ErrDefaultXXX errors that existed in gophercloud v1 to their net/http equivalent

We should try converting all ErrDefaultXXX errors that existed in
gophercloud v1 to their net/http equivalent.
@github-actions github-actions bot added the semver:patch No API change label Sep 11, 2024
Copy link
Copy Markdown
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 78.741%. remained the same
when pulling 02a183d on shiftstack:migration-script-improvements
into 63fae83 on gophercloud:master.

@EmilienM EmilienM merged commit 82a1eb2 into gophercloud:master Sep 11, 2024
@EmilienM EmilienM deleted the migration-script-improvements branch September 11, 2024 15:33
@EmilienM
Copy link
Copy Markdown
Contributor

Thanks, it was on my list as well!!

@pierreprinetti pierreprinetti added the backport-v2 This PR will be backported to v2 label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants