Align ServiceFail provisioning state value with Ironic#3131
Merged
pierreprinetti merged 1 commit intogophercloud:masterfrom Jul 23, 2024
Merged
Align ServiceFail provisioning state value with Ironic#3131pierreprinetti merged 1 commit intogophercloud:masterfrom
pierreprinetti merged 1 commit intogophercloud:masterfrom
Conversation
There is a mismatch between ServiceFail values used by Gophercloud and Ironic. Ironic uses "service failed" value [1], rather than "service fail". This commit addresses this discrepancy. [1] https://github.com/openstack/ironic/blob/stable/2024.1/ironic/common/states.py#L248 Signed-off-by: Przemyslaw Szczerbik <przemyslaw.szczerbik@intel.com>
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
Contributor
Author
|
FYI @dtantsur |
dtantsur
approved these changes
Jul 22, 2024
Contributor
dtantsur
left a comment
There was a problem hiding this comment.
LGTM, thanks. The "major" semver tag is quite incorrect IMO.
|
Failed to backport PR to |
Member
|
I consider this to be a patch, however the support for servicing was never backported to v1, so this patch only applies to v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a mismatch between ServiceFail values used by Gophercloud and Ironic. Ironic uses "service failed" value [1], rather than "service fail". This commit addresses this discrepancy.
Fixes #3130
[1] https://github.com/openstack/ironic/blob/stable/2024.1/ironic/common/states.py#L248