Merged
Conversation
Contributor
|
awesome! thanks |
e621f47 to
6104d02
Compare
6104d02 to
919a982
Compare
919a982 to
012b916
Compare
012b916 to
e1ed5a3
Compare
EmilienM
previously approved these changes
May 22, 2024
Contributor
Author
|
@EmilienM The failures of the EDIT: tbc, this is separate from the failures against |
Contributor
|
@dtantsur FYI |
521d30c to
8d337d5
Compare
8d337d5 to
ed25b1f
Compare
Contributor
Author
|
aaand of course the master job is passing now. Typical 🙄 There's a new failure but that seems to be an upper-constraint conflict |
ed25b1f to
735bc6a
Compare
90794e5 to
275b2ec
Compare
It's more common than the object storage service and allows us to run on a DevStack with default configuration. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We mangled this, probably since we were renaming the 'imageservice' module to 'image' at the time. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
For use in CI. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Contributor
Author
|
I hit this every time I go write Gophercloud code 😅 Let's see if those failures were real or not. |
275b2ec to
7fe2ee2
Compare
So we can run 'make unit' again. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
These have crept in since ce56d12 as we are not currently running golangci-lint in CI. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We can remove the 'acceptancetest' script in the process. Note that this isn't a 1:1 match: the fwaasv2 test job now runs the entire networking test suite and not just the fwaasv2-specific tests but seeing as this is using OVS rather than OVN that doesn't seem like such a bad thing. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Users can use 'make unit' for this now. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We no longer test on Ubuntu 20.04. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
7fe2ee2 to
0572399
Compare
Contributor
Author
|
Looks like some new functional tests have crept in without the |
Contributor
Author
mandre
approved these changes
May 7, 2025
|
Failed to backport PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start using the Makefile added in #2940 for our CI jobs.
Depends-on: #3064