Merged
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
821b89f to
b20f659
Compare
b20f659 to
730e08d
Compare
730e08d to
65d6f84
Compare
This was referenced Mar 21, 2024
This has not been used since we migrated to Travis. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
...to ensure we set the GOFLAGS correctly. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Well, mostly consistent: the acceptancetest script needs some special treatment due to DevStack being weird. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
I'm guessing this was here to ensure we respected the exit code of the 'go test' invocation. We now do this through the appropriate use of 'set' so we no longer need to use 'exec'. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We now use 'go vet' in CI, which includes import checks. Since we don't want to *fix* these failures in CI - merely report them - this is a better choice. Drop 'goimports' in favour of 'gofmt'. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
I often see failing "unit tests" only to discover the actual failures are linter related. Move these linter jobs to a separate workflow to avoid this confusion going forward. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This is already run as part of the 'unit' workflow. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Now that we skip tests that require optional features or extensions, we can use standard module discovery rather than a glob of bash to run our tests. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This isn't necessary since Go 1.16 [1]. [1] https://maelvls.dev/go111module-everywhere/ Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
65d6f84 to
f2c3732
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started out as a series to add a
go vettask to our CI jobs but transformed into a much larger PR to fix complaints I had with out current CI process 🙂.The main change here is modify our tests so that we do not need so many wrappers around
go test. This means making consistent use of conditional compilation directives to skip integration tests when running e.g.go test ./...and adding helper utilities to skip tests that rely on non-standard extensions or deployment configuration. The end result is that it should be possible to mostly usego testwithout wrappers going forward (though the wrappers are kept for now).Please look at the individual commits for my rationale behind each change.