Skip to content

testhelper: mark all helpers with t.Helper#2997

Merged
mandre merged 1 commit intogophercloud:masterfrom
sardinasystems:mark-testhelpers-as-helper
Mar 18, 2024
Merged

testhelper: mark all helpers with t.Helper#2997
mandre merged 1 commit intogophercloud:masterfrom
sardinasystems:mark-testhelpers-as-helper

Conversation

@vooon
Copy link
Copy Markdown
Contributor

@vooon vooon commented Mar 18, 2024

Fixes #2996

Fixes gophercloud#2996

Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
@vooon vooon mentioned this pull request Mar 18, 2024
@mandre mandre changed the title v2: testhelper: mark all helpers with t.Helper testhelper: mark all helpers with t.Helper Mar 18, 2024
@mandre mandre added the backport-v1 This PR will be backported to v1 label Mar 18, 2024
@github-actions github-actions bot added the semver:patch No API change label Mar 18, 2024
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 77.253%. remained the same
when pulling 7b093f0 on sardinasystems:mark-testhelpers-as-helper
into 016924c on gophercloud:master.

@mandre mandre merged commit 0acf4d6 into gophercloud:master Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v1 This PR will be backported to v1 semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test helpers should be marked with t.Helper()

3 participants